Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, use test proxy for confidential ledger #34585

Merged
merged 3 commits into from
Apr 26, 2023
Merged

mgmt, use test proxy for confidential ledger #34585

merged 3 commits into from
Apr 26, 2023

Conversation

haolingdong-msft
Copy link
Member

@haolingdong-msft haolingdong-msft commented Apr 21, 2023 •
edited
Loading

Description

Link #34243

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Apr 21, 2023 •
edited
Loading

I assume we can actually check it in.

@haolingdong-msft haolingdong-msft marked this pull request as ready for review April 23, 2023 02:30
@haolingdong-msft
Copy link
Member Author

haolingdong-msft commented Apr 23, 2023 •
edited
Loading

Hi @samvaity , this is our first package that adopts testproxy, this pr includes update test code and recordings. Please help to review and approve.

@samvaity samvaity mentioned this pull request Apr 25, 2023
Closed
@haolingdong-msft haolingdong-msft merged commit 8149a46 into Azure:main Apr 26, 2023
@joshfree
Copy link
Member

Thank you @haolingdong-msft and @weidongxu-microsoft for starting the onboarding process to testproxy!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@samvaity samvaity samvaity approved these changes

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haolingdong-msft @azure-sdk @weidongxu-microsoft @joshfree @samvaity